Skip to content

[O2B-1291] Make RCT runs tables' headers sticky#1935

Merged
xsalonx merged 26 commits into
mainfrom
xsalonx/O2B-1291/freeze-column-and-header
Jul 23, 2025
Merged

[O2B-1291] Make RCT runs tables' headers sticky#1935
xsalonx merged 26 commits into
mainfrom
xsalonx/O2B-1291/freeze-column-and-header

Conversation

@xsalonx

@xsalonx xsalonx commented Jul 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • RCT's runs tables have internal scrolling, and their headers are sticky

Notable changes for developers:

  • Refactor table component
  • Add verticalScrollEnabled param

Changes made to the database:

  • NA

@xsalonx xsalonx self-assigned this Jul 21, 2025
@codecov

codecov Bot commented Jul 21, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 45.71%. Comparing base (b8e5f45) to head (4c2f7b9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/public/components/common/table/table.js 0.00% 14 Missing ⚠️
.../Runs/RunPerPeriod/RunsPerLhcPeriodOverviewPage.js 0.00% 2 Missing ⚠️
lib/public/views/Runs/Overview/RunsWithQcModel.js 0.00% 1 Missing ⚠️
...imulationPass/RunsPerSimulationPassOverviewPage.js 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1935      +/-   ##
==========================================
- Coverage   45.76%   45.71%   -0.05%     
==========================================
  Files        1010     1010              
  Lines       16667    16676       +9     
  Branches     2985     2993       +8     
==========================================
- Hits         7628     7624       -4     
- Misses       9039     9052      +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xsalonx xsalonx marked this pull request as ready for review July 23, 2025 08:26
@xsalonx xsalonx requested a review from graduta as a code owner July 23, 2025 08:26
@xsalonx xsalonx changed the title [O2B-1291] RCT tables' header [O2B-1291] Make RCT runs tables' headers sticky Jul 23, 2025
xsalonx added 2 commits July 23, 2025 10:47
@xsalonx
fix
35a28ed
@xsalonx
Revert "fix"
4c2f7b9 
This reverts commit 35a28ed.
@xsalonx xsalonx merged commit d0ae17e into main Jul 23, 2025
38 of 41 checks passed
@xsalonx xsalonx deleted the xsalonx/O2B-1291/freeze-column-and-header branch July 23, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graduta graduta graduta approved these changes

Assignees

@xsalonx xsalonx

Labels

frontend

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xsalonx @graduta